tests(mark_sweep): add coverage for merged parity helpers#67
Merged
nekevss merged 1 commit intoboa-dev:mainfrom Mar 30, 2026
Merged
tests(mark_sweep): add coverage for merged parity helpers#67nekevss merged 1 commit intoboa-dev:mainfrom
nekevss merged 1 commit intoboa-dev:mainfrom
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds focused test coverage for the parity helper APIs that were merged from #64, #65, and #66.
Refs: #63
What this adds
mark_sweeptests for:Gc::into_raw/Gc::from_rawround-trip identity and value stabilityGc::downcast/Gc::cast_uncheckedparity behaviorWeakGc::upgradeliveness behavior before and after collectionmark_sweep2(mark_sweep_arena2) for the same helper setWhy
In #63, maintainer feedback called out that parity was in a good place but these newly added helpers still needed tests.
This PR keeps scope strictly to tests for those merged parity APIs.
Scope
Validation
cargo fmt --all -- --checkcargo test --workspace